windows: added platform abstraction headers#3237
windows: added platform abstraction headers#3237bgoing-micron-oss wants to merge 1 commit intolinux-nvme:masterfrom
Conversation
Added Windows and LInux platform abstraction headers. Updated files that include platform-specific files to include the new platform compatibility headers. Platform abstraction headers get installed under the platform subfolder. Signed-off-by: Broc Going <[email protected]>
|
As discussed during our call, I am not really a big fan of this approach. It creates a header file which includes everything and everything is depended on this header. From experience this gets easily out of hand. Thus I decided to go through the existing code and split/refactor the code so that there is generic code which is supposed to work on all platforms and platform depended code. The build system needs to pull in the right files. In the end the only Windows specific changes are the the new headers types.h ( Obviously, there is still more cleanups necessary (I am working on refactoring the fabrics code for the libnvme_fabrics_option removal from the API anyway) but I think with this in place the porting path is unlocked. |
2 participants
Added Windows and Linux platform abstraction headers. Updated files that include platform-specific files to include the new platform compatibility headers.
Platform abstraction headers get installed under the platform subfolder.